chore(deps): bump ANcpLua.NET.Sdk to 3.4.39#157
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96b6bc46c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| "msbuild-sdks": { | ||
| "ANcpLua.NET.Sdk": "3.4.38", | ||
| "ANcpLua.NET.Sdk": "3.4.39", |
There was a problem hiding this comment.
Bump the SDK variants together
With this line moved to 3.4.39 while ANcpLua.NET.Sdk.Web remains at 3.4.38, only projects that use the base SDK get the new SDK behavior; the repo also has Sdk="ANcpLua.NET.Sdk.Web" projects under samples/ and tests/ErrorOrX.Integration.Tests/, so solution-wide builds still evaluate part of the tree on the old SDK. Since the published SDK docs show these three variants being pinned as a matched set and 3.4.39 exists for the Web/Test variants too, this leaves the dependency bump only partially applied and can produce inconsistent analyzer/tooling behavior between library and web projects.
Useful? React with 👍 / 👎.
Bumps the
ANcpLua.NET.Sdkmsbuild-sdk pin inglobal.jsonfrom 3.4.38 to 3.4.39.3.4.39 drops Meziantou.Framework.DependencyScanning + YamlDotNet (replaced by a zero-dep XDocument scan in the config generator) and refreshes analyzer/tooling pins.
Generated with Claude Code