numInputImageItems to avifImageApplyExpression32b#2986
Open
wantehchang wants to merge 1 commit intoAOMediaCodec:mainfrom
Open
numInputImageItems to avifImageApplyExpression32b#2986wantehchang wants to merge 1 commit intoAOMediaCodec:mainfrom
wantehchang wants to merge 1 commit intoAOMediaCodec:mainfrom
Conversation
Pass numInputImageItems (the size of the inputImageItems array) to avifImageApplyExpression32b(). Validate the index for the inputImageItems array.
vrabaud
approved these changes
Jan 31, 2026
| } else if (token->type == AVIF_SAMPLE_TRANSFORM_INPUT_IMAGE_ITEM_INDEX) { | ||
| const avifImage * image = inputImageItems[token->inputImageItemIndex - 1]; // 1-based | ||
| // inputImageItemIndex is 1-based. | ||
| const uint8_t zeroBasedIndex = token->inputImageItemIndex - 1; |
Contributor
There was a problem hiding this comment.
There is absolutely no way inputImageItemIndex is 0 I guess?
Contributor
There was a problem hiding this comment.
Indeed. It is checked in avifSampleTransformExpressionIsValid(), but so is inputImageItemIndex <= numInputImageItems.
y-guyon
approved these changes
Feb 2, 2026
| } else if (token->type == AVIF_SAMPLE_TRANSFORM_INPUT_IMAGE_ITEM_INDEX) { | ||
| const avifImage * image = inputImageItems[token->inputImageItemIndex - 1]; // 1-based | ||
| // inputImageItemIndex is 1-based. | ||
| const uint8_t zeroBasedIndex = token->inputImageItemIndex - 1; |
Contributor
There was a problem hiding this comment.
Indeed. It is checked in avifSampleTransformExpressionIsValid(), but so is inputImageItemIndex <= numInputImageItems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass numInputImageItems (the size of the inputImageItems array) to avifImageApplyExpression32b(). Validate the index for the inputImageItems array.