Fix useTuneIq comment in aomCodecEncodeImage()#2999
Merged
y-guyon merged 1 commit intoAOMediaCodec:mainfrom Feb 6, 2026
Merged
Fix useTuneIq comment in aomCodecEncodeImage()#2999y-guyon merged 1 commit intoAOMediaCodec:mainfrom
y-guyon merged 1 commit intoAOMediaCodec:mainfrom
Conversation
wantehchang
approved these changes
Feb 5, 2026
| // False otherwise (including if libaom uses tune=iq by default, which is not the case as of v1.13.1 and earlier versions). | ||
| // This is only accurate for the first frame but tune=iq is only supported for still images in libavif and | ||
| // for all-intra coding in libaom (at least up to v1.13.1) anyway. | ||
| // False otherwise (including if libaom uses tune=iq by default, which is not the case as of v3.13.1 and earlier versions). |
Collaborator
There was a problem hiding this comment.
I think we need to impose a constraint that the tune option can only be set before encoding starts. Then we can store the result of avifImageUsesTuneIq() in the codec->internal structure.
There was a problem hiding this comment.
100% agreed, I'll take a look at implementing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment at the end of
avifImageUsesTuneIq()already describes that it is only valid for the first frame, so this comment is not necessary, andavifImageUsesTuneIq()will be updated anyway (see #2997).