Resolve the problem with the color prompt messing up cursor position#45
Merged
Resolve the problem with the color prompt messing up cursor position#45
Conversation
When scrolling through history with ↑/↓, once a sufficiently long line was shown, the cursor would not be returned to the beginning of the line and a portion of the previous line would be shown. It turns out that this can be avoided if we wrap the color escape sequences with \1 … \2, which tells the terminal (?) that the sequence is zero-width. (The sequence is for the terminal, but maybe python, or libreadline, is smart enough to take this into account. I'm hazy on the details.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When scrolling through history with ↑/↓, once a sufficiently long line was shown, the cursor would not be returned to the beginning of the line and a portion of the previous line would be shown.
It turns out that this can be avoided if we wrap the color escape sequences with \1 … \2, which tells the terminal (?) that the sequence is zero-width. (The sequence is for the terminal, but maybe python, or libreadline, is smart enough to take this into account. I'm hazy on the details.)