-
Notifications
You must be signed in to change notification settings - Fork 9
#162: release automation and documentation update #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3eba8ca
#162: release automation and documentation update
lsulak 939054e
post-review fixes
lsulak e51fcdc
fixing unit tests: the '+' needed for sbt-dynver snapshot versions, e…
lsulak 2b18089
adding myself as future maintainer and also fixed non-determinism in …
lsulak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # | ||
| # Copyright 2018 ABSA Group Limited | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
||
| name: Release | ||
| on: | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| publish: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd #v6.0.2 | ||
| with: | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
|
|
||
| - name: Setup Scala | ||
| uses: olafurpg/setup-scala@32ffa16635ff8f19cc21ea253a987f0fdf29844c #v14 | ||
| with: | ||
| java-version: "adopt@1.8" | ||
|
|
||
| - run: sbt ci-release | ||
| env: | ||
| PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }} | ||
| PGP_SECRET: ${{ secrets.PGP_SECRET }} | ||
| SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }} | ||
| SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Release | ||
|
|
||
| Releases of this library are currently handled by [sbt-ci-release](https://github.com/sbt/sbt-ci-release). | ||
| Please see its documentation for more details about how it works if you are interested to know more. | ||
|
|
||
| The actual deployments are triggered manually by the maintainers of this repository, using `workflow_dispatch` event | ||
| trigger. | ||
|
|
||
| Once changes from a PR were reviewed and merged into the master branch, follow these steps: | ||
| 1. Create a new Git Tag at the desired commit on `master`, and push the tag to the repository. For example, | ||
| if you want to release a version 0.4.0 (note that we are using [Semantic Versioning](https://semver.org/)): | ||
|
|
||
| ```shell | ||
| git tag -a v0.4.0 -m "v0.4.0" | ||
| git push origin v0.4.0 | ||
| ``` | ||
|
|
||
| 2. In GitHub UI, go to the repository's **Actions** -> **Release** -> **Run workflow**, and under **Use workflow from** | ||
| use **Tags** and find the tag you created in the previous step. | ||
|
|
||
| > **Important note**: don't run the workflow against the master branch, but against the tag. | ||
| > `sbt-ci-release` plugin won't be able to correctly find tag, and it will think that you are trying | ||
| > to do a snapshot release, not an actual release that should be synchronized with Maven Central. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,7 @@ trait ControlMeasureBaseTestSuite { | |
| .replaceFirst("""(?<="informationDate"\s?:\s?")(\d{2}-\d{2}-\d{4})""", testingDate) | ||
| .replaceAll("""(?<="processStartTime"\s?:\s?")([-+: \d]+)""", testingDateTime1) | ||
| .replaceAll("""(?<="processEndTime"\s?:\s?")([-+: \d]+)""", testingDateTime2) | ||
| .replaceAll("""(?<="version"\s?:\s?")([-\d\.A-z]+)""", testingVersion) | ||
| .replaceAll("""(?<="version"\s?:\s?")([-+\d\.A-z]+)""", testingVersion) | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. note - I removed the version from the SBT files because it will be detected from git tag and the tests were more exact before |
||
| .replaceAll("""(?<="software"\s?:\s?")([\d\.A-z_]+)""", testingSoftware) | ||
| .replaceAll("\r\n", "\n") // Windows guard | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,4 +13,4 @@ | |
| # limitations under the License. | ||
| # | ||
|
|
||
| sbt.version = 1.9.9 | ||
| sbt.version=1.11.5 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential race condition in file
HdfsInfoIntegrationSuite.scalafor Spark 3.2+