feat: add navigationBarTranslucent prop for Android navigation bar support#225
Open
Sameed1998 wants to merge 1 commit intoAdelRedaa97:masterfrom
Open
feat: add navigationBarTranslucent prop for Android navigation bar support#225Sameed1998 wants to merge 1 commit intoAdelRedaa97:masterfrom
Sameed1998 wants to merge 1 commit intoAdelRedaa97:masterfrom
Conversation
…pport - Add navigationBarTranslucent prop to SelectDropdown component - Update TypeScript definitions with new prop - Pass navigationBarTranslucent to DropdownModal component - Support for Android navigation bar transparency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for
navigationBarTranslucentprop to handle Android navigation bar transparency in the dropdown modal.Changes Made
navigationBarTranslucentprop toSelectDropdowncomponentindex.d.tswith proper JSDoc commentsDropdownModalcomponent to accept and pass the new prop to React Native's ModalTechnical Details
navigationBarTranslucent?: booleanfalse(maintains backward compatibility)statusBarTranslucentpropUse Case
This feature is useful for Android apps that use translucent navigation bars, allowing the dropdown modal to properly handle the navigation bar area.
Backward Compatibility
Files Modified
src/SelectDropdown.js- Added prop parameter and passingsrc/components/DropdownModal.js- Added prop handling and Modal integrationindex.d.ts- Added TypeScript definition with documentationTesting