fix: Rename variables and upgrade shield sprites to multipart

[OH296]

Purpose and Description

• Self-descriptive.

Testing done

• None, and I understand the risks.

Related things and/or additional context

---

Summary by cubic

Renamed the weapon rendering flag to single_left_right_profile and moved Storm Shield sprites to a multipart setup with subcomponents. This clarifies intent and enables richer shield variants without duplicating sprites.

• New Features

  • Storm Shield now supports multipart rendering via subcomponents (primary decoration + boss layer).
  • Added sprites: spr_weapon_storm_boss, spr_weapon_storm_complex, spr_weapon_storm_primary_decoration; removed spr_weapon_storm_tall and spr_weapon_storm_tall_2.
  • Simplified spr_weapon_storm to one frame and updated bounds; registered new assets in the project.

• Refactors

  • Renamed new_weapon_draw to single_left_right_profile across weapon data and UI.
  • Updated draw checks and offsets in scr_ComplexSet, scr_culture_visuals, and scr_ui_display_weapons to use the new flag.

^{Written for commit 13d10e8. Summary will update on new commits. Review in cubic}

[cubic-dev-ai]

1 issue found across 32 files

Confidence score: 3/5

• There is a concrete medium-severity regression risk: in scripts/scr_culture_visuals/scr_culture_visuals.gml, single_left_right_profile is set at variant scope but dropped before draw, so the shield variant can miss its intended single-profile rendering path.
• I chose a moderate-risk score because the issue is user-facing behavior with high confidence (6/10 severity, 9/10 confidence), even though it appears localized to one script rather than a broad architectural problem.
• Pay close attention to scripts/scr_culture_visuals/scr_culture_visuals.gml - ensure variant-scoped single_left_right_profile survives to the draw logic for shield rendering.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="scripts/scr_culture_visuals/scr_culture_visuals.gml">

<violation number="1" location="scripts/scr_culture_visuals/scr_culture_visuals.gml:3246">
P2: `single_left_right_profile` added at variant scope is dropped before draw; shield variant will not use the intended single-profile path.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[github-actions]

This PR is marked as stale, because it has been open for 7 days with no activity.