refactor(ecs): remove forEach, rename iterate to items#54
refactor(ecs): remove forEach, rename iterate to items#54RigidStudios wants to merge 2 commits intomainfrom
forEach, rename iterate to items#54Conversation
|
@christopher-buss Do we need tests for this? There were never any tests for |
|
I don't think we should do this. I'd rather have an iterate() and a items() method if you want all the items. We'd have to traverse every entity and add it to a table.. just to re-traverse it later on when we want to use it. I'm happy to have both, but I don't want to remove the generalised iterator completely. I didn't realise you were doing this, I was currently doing it in another branch! |
|
Alright, I'll restore iterate but rename to |
I huffed and puffed about it yesterday, of course I'll do it! 😂 |
|
Docs done in AetherInteractiveLtd/docs#2 |
|
We'll prefer #55 |
Description
Removes
Query#forEachas proposed in #42. Also resolves #47 by renamingQuery#iteratetoQuery#items.Tasks
Documentation
Linked
Resolves #42
Resolves #47
Resolves AetherInteractiveLtd/docs#2