-
Notifications
You must be signed in to change notification settings - Fork 9
Add table operation in SweepFormula #2171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a minimum viable product (MVP) for the table operation in SweepFormula, allowing data to be displayed in a table format instead of the default graph view.
- Adds a new
tableoperation that can be applied to datasets - Modifies the plotting logic to display data as an editable table when the table operation is used
- Implements basic table functionality without support for advanced features like
vs,with, orandoperations
90e95b9 to
529c345
Compare
|
@timjarsky Here is a first version for playing around. If you enclose an expression in The table(s) are in a separate panel. f.e. results in two panels with two sub windows each, one with two tables and the other with two plots. One subwindow with one table and two columns. Expressions added with Also multiple datasets from a single expression result in new columns per dataset. Special case mixing: Is split into a table and a plot. If you use only tables or only plots the second window is not presented as it would contain no data. SF_DM_NORMAL display mode is supported as well. |
|
@MichaelHuth The runners work again. The failure in https://github.com/AllenInstitute/MIES/actions/runs/19199707109/job/55010723400 is our documentation check. |
|
@MichaelHuth This is working well. Please add a right-click menu option to bring the databrowser to the front, similar to what we do for the plots. Also, could you make the dimension labels on the tables more informative? Thank you. |
Why in a separate panel and not as a subwindow in the existing one? |
In the current panel as a subwindow the resulting size of the table might be two small and it could be inconvenient to use without additional elements to change the guide to adjust subwindow distribution. Also the complexity stays similar as a user can have a formula like: then this results in a plot and a table. In a single panel I would also need to reserve subwindows for each display type and remove empty ones afterwards. If you think that moving different display types to a new panel is too inflationary regarding the number windows I can wrap everything in the same panel. |
This is the equivalent for RemoveTracesFromGraph for plots with the base functionality. Function: RemoveAllColumnsFromTable
529c345 to
40341b0
Compare
I changed the table that it shows dimension labels. The dimension labels are from the data waves that are from the result in the expression in In Igor 10 for tables also tooltips work. I can retrieve the indices and the wave where the cursor is currently positioned. So it would be possible to generate some tooltip text including information present in the JSON wave note. |
Tables introduce a second type of displaying data (after plots) to the plotter. Tables are displayed in a separate panel. Therefore in SF_PreparePlotter the plotGraphs wave that lists all window names is extended with a new row for the names of the table subwindows. The creation of plotGraphs is moved to an own getter function. The panel or window creation for SF_DM_NORMAL mode is moved to an own function SF_NewSweepFormulaBaseWindow For the equivalent of RemoveTracesFromGraph the function RemoveAllColumnsFromTable is used for tables. Since not all SubWindows prepared by SF_PreparePlotter might be used in plotting the subWindows (SF_DM_SUBWINDOWS mode) are tiled only between the windows that actually contain data after all data was plotted in SF_TileExistingData.
operation tags the output wave to hint the plotter that the data should be displayed in a table. The operation does not change the data otherwise. table(expression)
40341b0 to
832c2b7
Compare
Can the tooltip show the formula which created the table column? If yes I'd say it's worth the effort. |
Implement a MVP
vswithandgives