Task/3 19 2026 json schema for filters extended edition#1676
Open
emily-howell wants to merge 62 commits intodevelopfrom
Open
Task/3 19 2026 json schema for filters extended edition#1676emily-howell wants to merge 62 commits intodevelopfrom
emily-howell wants to merge 62 commits intodevelopfrom
Conversation
… format. Also adding additional validator constructs needed to complete this.
…2025-json-schema-for-filters
…2025-json-schema-for-filters
(Also fixing a bug in the dray rendering filter :( )
emily-howell
changed the base branch from
task/2_3_2025-json-schema-for-filters
to
develop
…pine-DAV/ascent into task/3_19_2026-json-schema-for-filters-extended-edition
…pine-DAV/ascent into task/3_19_2026-json-schema-for-filters-extended-edition
…_2026-json-schema-for-filters-extended-edition
…2025-json-schema-for-filters
…pine-DAV/ascent into task/3_19_2026-json-schema-for-filters-extended-edition
…xtended edition filters too
…pine-DAV/ascent into task/3_19_2026-json-schema-for-filters-extended-edition
… array schema elements are ignored unless a schema is provided.
cyrush
reviewed
Apr 13, 2026
Member
cyrush
left a comment
cyrush
left a comment
There was a problem hiding this comment.
Looks good, a few small suggestions and you can fill me in on how they ignore logic cascades.
| ignore_schema(visit_camera_schema["properties/far_plane"]); | ||
| ignore_schema(visit_camera_schema["properties/image_pan"]); | ||
| ignore_schema(visit_camera_schema["properties/image_zoom"]); | ||
| ignore_schema(visit_camera_schema["properties/perspective"]); |
Member
There was a problem hiding this comment.
ignore_schema allows these to exist in any form, correct?
…_2026-json-schema-for-filters-extended-edition
Member
Author
|
I don't think the CI failures are related to this MR or the changes I just pushed as I am also seeing them on my #1688 MR |
…_2026-json-schema-for-filters-extended-edition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a second pass at this task that converts the remainder of the
verify_paramsfunctions into conduit json schema nodes for validation. Additional capabilities were added to the schema validator to support these changes.This PR builds on #1663 and should be merged after it