Task/4 2 2026 1027 plotting with just one color#1691
Open
emily-howell wants to merge 107 commits into
Open
Conversation
… format. Also adding additional validator constructs needed to complete this.
…2025-json-schema-for-filters
…2025-json-schema-for-filters
(Also fixing a bug in the dray rendering filter :( )
Signed-off-by: Emily Howell <howell31@llnl.gov>
… array schema elements are ignored unless a schema is provided.
…' of github.com:Alpine-DAV/ascent into task/3_24_2026-json-schema-for-filters-documentation-edition
…ition' of github.com:Alpine-DAV/ascent into task/4_2_2026-1027-plotting-with-just-one-color
Member
|
Since this builds off of the params refactor, I can't really isolate the changes for the mesh plotting easily. I will review when we have the other changes merged in. |
…_2026-json-schema-for-filters-extended-edition
…' of github.com:Alpine-DAV/ascent into task/3_24_2026-json-schema-for-filters-documentation-edition
…_2026-json-schema-for-filters-extended-edition
…' of github.com:Alpine-DAV/ascent into task/3_24_2026-json-schema-for-filters-documentation-edition
cyrush
reviewed
May 14, 2026
| conduit::Node scenes; | ||
| scenes["s1/plots/p1/type"] = "pseudocolor"; | ||
| scenes["s1/plots/p1/field"] = "braid"; | ||
| scenes["s1/plots/p1/color"] = {0.0, .184, .655}; // {0.748, 0.004, 0.008} |
Member
There was a problem hiding this comment.
how about
Suggested change
| scenes["s1/plots/p1/color"] = {0.0, .184, .655}; // {0.748, 0.004, 0.008} | |
| scenes["s1/plots/p1/color_table/solid"] = {0.0, .184, .655}; |
…_2026-json-schema-for-filters-documentation-edition
…_2026-json-schema-for-filters-documentation-edition
…ition' of github.com:Alpine-DAV/ascent into task/4_2_2026-1027-plotting-with-just-one-color
…ocs to build locally and now I should actually make them look right too
…ition' of github.com:Alpine-DAV/ascent into task/4_2_2026-1027-plotting-with-just-one-color
…ition' of github.com:Alpine-DAV/ascent into task/4_2_2026-1027-plotting-with-just-one-color
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented for both VTK-H and Devil Ray rendering. I took two different approaches. The implementation in the Devil Ray parsing builds a color_table with the one color and passes it to parse color table, the other just sets the color table directly. Curious which is prefered.
Also, I built this on top of the Json Schema changes. I figured it was easier to implement the changes to the parameter checking there then to have to update them later.