Minor fixes to avoid annoying compilation-time warnings whenever any …#1072
Merged
AngusJohnson merged 1 commit intoAngusJohnson:mainfrom Mar 5, 2026
Merged
Conversation
…code includes the Clipper2 headers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm compiling my program (that uses Clipper2) using Apple's clang++, with lots of warnings enabled, i.e. with flags including these:
.... and as a result of that, when I compile any of my .cpp files that #include the Clipper2 header files, I get a few warnings about the code in the headers (as seen in the attached file). They are pretty minor issues, but I'm trying to get my compile-logs to be as warning-free as possible so it would be nice if the headers got fixed so that the warnings do not occur.
clipper2_compile_time_warnings.txt