Fix linking to m.lib on Windows with clang#1080
Merged
AngusJohnson merged 1 commit intoAngusJohnson:mainfrom Mar 20, 2026
Merged
Fix linking to m.lib on Windows with clang#1080AngusJohnson merged 1 commit intoAngusJohnson:mainfrom
m.lib on Windows with clang#1080AngusJohnson merged 1 commit intoAngusJohnson:mainfrom
Conversation
We separate configuring warnings and linking to the math library. This way, it works for clang on Windows when using Microsoft's standard library.
Contributor
Author
|
Note: the previous fix for MinGW was here #337. This is a fix for clang on Windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old code was doing 2 unrelated things: configuring warnings and linking to the standard math library implementation. Warnings depend on the compiler frontend, which can be tested using
CMAKE_CXX_COMPILER_FRONTEND_VARIANT.Then, we check whether we need to link to a math library. Microsoft's implementation of the C standard library includes the math library. Old code worked for MSVC and MinGW I am assuming, but did not work for clang with
lld-link: error: could not open 'm.lib': no such file or directory. I only tested the new version with clang and it does not give the above error.