APL - 1676 nodeID #1111
Open
APL - 1676 nodeID #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oundation/Apollo into feature/APL-1676-node-id
# Conflicts: # pom.xml
…oundation/Apollo into feature/APL-1676-node-id
…oundation/Apollo into feature/APL-1676-node-id
…oundation/Apollo into feature/APL-1676-node-id
oleksiylukin
requested review from
0486,
AndrewBoyarsky,
oleksiylukin and
yuriy-ln
…oundation/Apollo into feature/APL-1676-node-id # Conflicts: # apl-core/src/main/java/com/apollocurrency/aplwallet/apl/core/peer/PeerImpl.java
Collaborator
|
Required artifactory deployment for the fb-identity |
Collaborator
AndrewBoyarsky
left a comment
AndrewBoyarsky
left a comment
There was a problem hiding this comment.
Waiting for artifactory deploy, review is on the way
apl-core/src/main/java/com/apollocurrency/aplwallet/apl/security/id/IdentityServiceImpl.java
Show resolved
Hide resolved
# Conflicts: # apl-core/src/main/java/com/apollocurrency/aplwallet/apl/core/peer/PeersService.java # apl-core/src/main/java/com/apollocurrency/aplwallet/apl/core/transaction/TransactionValidator.java
apl-core/src/main/java/com/apollocurrency/aplwallet/apl/core/entity/appdata/BlockIndex.java
Show resolved
Hide resolved
…to the apl-bom-ext, fix copyrights/typos/docs/logs
…ake DefaultConfigDirProvider thread safe, remove unused beans.xml for non-weld modules, make apl-utils weld-independent
Collaborator
AndrewBoyarsky
left a comment
AndrewBoyarsky
left a comment
There was a problem hiding this comment.
Updated, tested, works fine.
Do not merge for a while
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certificate-based NodeID feature implementation