Skip to content

fix: use WindowInsetsCompat to exclude keyboard insets on Android API 23-29 #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tp26610 wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −6
Open

fix: use WindowInsetsCompat to exclude keyboard insets on Android API 23-29 #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2166291
fix: use WindowInsetsCompat to exclude keyboard insets on Android API…
tp26610 Apr 27, 2026
eba9d58
refactor: narrow fix to only correct bottom inset, keep systemWindowI…
tp26610 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,4 +121,5 @@ def kotlin_version = getExtOrDefault('kotlinVersion', project.properties['RNSAC_
dependencies {
implementation 'com.facebook.react:react-native:+'
implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
implementation 'androidx.core:core-ktx:1.9.0'
}
22 changes: 16 additions & 6 deletions android/src/main/java/com/th3rdwave/safeareacontext/SafeAreaUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import android.view.View
import android.view.ViewGroup
import android.view.WindowInsets
import androidx.annotation.RequiresApi
import androidx.core.view.ViewCompat
import androidx.core.view.WindowInsetsCompat
import java.lang.IllegalArgumentException
import kotlin.math.max
import kotlin.math.min
Expand All @@ -29,15 +31,23 @@ private fun getRootWindowInsetsCompatR(rootView: View): EdgeInsets? {
@Suppress("DEPRECATION")
private fun getRootWindowInsetsCompatM(rootView: View): EdgeInsets? {
val insets = rootView.rootWindowInsets ?: return null
// Use WindowInsetsCompat to calculate the bottom inset without keyboard height.
// The deprecated min(systemWindowInsetBottom, stableInsetBottom) approach can
// incorrectly report keyboard height as the bottom inset on some Android 10
// devices (e.g. Samsung One UI, Nokia with stock Android), causing SafeAreaView
// to add paddingBottom equal to the keyboard height and push screen content up.
// WindowInsetsCompat.Type.navigationBars() explicitly excludes IME insets.
val bottomInset =
ViewCompat.getRootWindowInsets(rootView)
?.getInsets(
WindowInsetsCompat.Type.navigationBars() or WindowInsetsCompat.Type.displayCutout())
?.bottom
?.toFloat()
?: min(insets.systemWindowInsetBottom, insets.stableInsetBottom).toFloat()
return EdgeInsets(
top = insets.systemWindowInsetTop.toFloat(),
right = insets.systemWindowInsetRight.toFloat(),
// System insets are more reliable to account for notches but the
// system inset for bottom includes the soft keyboard which we don't
// want to be consistent with iOS. Using the min value makes sure we
// never get the keyboard offset while still working with devices that
// hide the navigation bar.
bottom = min(insets.systemWindowInsetBottom, insets.stableInsetBottom).toFloat(),
bottom = bottomInset,
left = insets.systemWindowInsetLeft.toFloat())
}

Expand Down