-
Notifications
You must be signed in to change notification settings - Fork 38
feat: total delegated voting power based quorum #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
godzillaba
wants to merge
26
commits into
main
Choose a base branch
from
delegate-total-poc-fixed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+941
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This reverts commit ace5bab.
TucksonDev
approved these changes
Oct 14, 2025
Collaborator
TucksonDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left one minor non-blocking comment.
godzillaba
commented
Oct 15, 2025
* use DVP in governor * remove relic of dvp estimation in quorum calc * Revert "remove relic of dvp estimation in quorum calc" This reverts commit 3af8bce. * keep old quorum behavior when checkpoint is old * add quorum clamping * document quorum jumping on admin function * comment * test governor dvp * update sigs and storage * fix test * add comment * snapshot
* use DVP in governor * first action * second action * fmt * comment * single action * remove relic of dvp estimation in quorum calc * Revert "remove relic of dvp estimation in quorum calc" This reverts commit 3af8bce. * Revert "single action" This reverts commit a132247. * keep old quorum behavior when checkpoint is old * add quorum clamping * set min/max quorum in action * document quorum jumping on admin function * comment * test governor dvp * fix rename functions * update sigs and storage * update sigs and storage * fix test * add prop1 test, use relay * remove second action * format * add comment * snapshot * fix test path * snapshot * update sigs and storage * undo toml change * Update src/gov-action-contracts/AIPs/TotalDvpQuorum/ActivateDvpQuorumAction.sol Co-authored-by: José FP <[email protected]> --------- Co-authored-by: José FP <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.