Skip to content

Conversation

@TucksonDev
Copy link
Collaborator

@TucksonDev TucksonDev commented Nov 12, 2025

This PR updates the gas snapshots and fixes the advisories found.

Yarn audit findings:

  • GHSA-4hjh-wcwx-xvwj ; updates axios dependency
  • GHSA-rx8g-88g5-qh64 : updates min-document dependency of safe-global/protocol-kit. In this case, protocol-kit is not updated, only the dependency itself, which should be safe since the new version only adds one new check (source)
  • GHSA-wqch-xfxh-vrr4 : depends on safe-global/protocol-kit, and we are using a very old version of the package to only update the dependency, so it's added to the allowlist
  • GHSA-hhf6-3xpg-pggx : hasn't been patched, so the advisory is added to the allowlist
  • GHSA-mh29-5h37-fv8m : yarn-audit-fix hasn't released a version with the fix. And hardhat won't probably release a new 2.x version with the fix.

@gzeoneth gzeoneth requested review from Copilot and gzeoneth November 26, 2025 13:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses security advisories by updating dependencies and adds a safeguard to prevent potential off-by-one errors in block range queries. The changes include updating axios and min-document dependencies, adding several advisories to the allowlist that cannot yet be fully resolved, and updating gas snapshots to reflect minor optimization improvements.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
scripts/tokenDistributorHelper.ts Adds boundary check to prevent querying beyond the end block when fetching contract events
audit-ci.jsonc Adds three unpatched security advisories to the allowlist (prototype pollution and DoS vulnerabilities)
.gas-snapshot Updates gas consumption measurements reflecting minor performance improvements across multiple test cases

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gzeoneth gzeoneth merged commit d517b4e into main Nov 26, 2025
14 of 15 checks passed
@gzeoneth gzeoneth deleted the update-snapshots-and-audit branch November 26, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants