feat(evals): serialize values accessed via nested selectors #10317
+412
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
dosubot
bot
added
size:L
commit: |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| if (Array.isArray(obj)) { | ||
| return obj.map(createTemplateVariablesProxy); | ||
| } |
There was a problem hiding this comment.
Bug: Arrays not JSON stringified in templates
Arrays accessed directly in templates use default toString() (comma-separated) instead of JSON stringification. The function maps array elements through the proxy but doesn't wrap the array itself, so {{items}} with items: ["a", "b"] renders as "a,b" instead of ["a","b"]. This is inconsistent with how objects are serialized and breaks the feature's intent to serialize nested values.
yfrigui2
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #10313