-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: stabilize packaged runtime pip/ssl behavior and mac font fallback #5007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f1ad258
fix: patch pip distlib finder for frozen electron runtime
zouyonghe b57312a
fix: use certifi CA bundle for runtime SSL requests
zouyonghe 1702ef2
fix: configure certifi CA before core imports
zouyonghe 38e74ec
fix: improve mac font fallback for dashboard text
zouyonghe 6b5591a
fix: harden frozen pip patch and unify TLS connector
zouyonghe 6517069
refactor: centralize dashboard CJK font fallback stacks
zouyonghe 7bac4ad
perf: reuse TLS context and avoid repeated frozen pip patch
zouyonghe d4df9ba
refactor: bootstrap TLS setup before core imports
zouyonghe ff73a55
fix: use async confirm dialog for provider deletions
zouyonghe 2e5841a
fix: replace native confirm dialogs in dashboard
zouyonghe 7e9d859
fix: capture runtime bootstrap logs after logger init
zouyonghe 82c43f5
fix: harden runtime bootstrap and unify confirm handling
zouyonghe 191b0c5
refactor: simplify runtime tls bootstrap and tighten confirm typing
zouyonghe ba884f7
refactor: align ssl helper namespace and confirm usage
zouyonghe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import logging | ||
| import ssl | ||
| import threading | ||
|
|
||
| import aiohttp | ||
|
|
||
| from astrbot.utils.http_ssl_common import ( | ||
| build_ssl_context_with_certifi as _build_ssl_context, | ||
| ) | ||
|
|
||
| logger = logging.getLogger("astrbot") | ||
|
|
||
| _SHARED_TLS_CONTEXT: ssl.SSLContext | None = None | ||
| _SHARED_TLS_CONTEXT_LOCK = threading.Lock() | ||
|
|
||
|
|
||
| def build_ssl_context_with_certifi() -> ssl.SSLContext: | ||
| """Build an SSL context from system trust store and add certifi CAs.""" | ||
| global _SHARED_TLS_CONTEXT | ||
|
|
||
| if _SHARED_TLS_CONTEXT is not None: | ||
| return _SHARED_TLS_CONTEXT | ||
|
|
||
| with _SHARED_TLS_CONTEXT_LOCK: | ||
| if _SHARED_TLS_CONTEXT is not None: | ||
| return _SHARED_TLS_CONTEXT | ||
|
|
||
| _SHARED_TLS_CONTEXT = _build_ssl_context(log_obj=logger) | ||
| return _SHARED_TLS_CONTEXT | ||
|
|
||
|
|
||
| def build_tls_connector() -> aiohttp.TCPConnector: | ||
| return aiohttp.TCPConnector(ssl=build_ssl_context_with_certifi()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import logging | ||
| import ssl | ||
| from typing import Any | ||
|
|
||
| import certifi | ||
|
|
||
| _LOGGER = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def build_ssl_context_with_certifi(log_obj: Any | None = None) -> ssl.SSLContext: | ||
| logger = log_obj or _LOGGER | ||
|
|
||
| ssl_context = ssl.create_default_context() | ||
| try: | ||
| ssl_context.load_verify_locations(cafile=certifi.where()) | ||
| except Exception as exc: | ||
| if logger and hasattr(logger, "warning"): | ||
| logger.warning( | ||
| "Failed to load certifi CA bundle into SSL context; " | ||
| "falling back to system trust store only: %s", | ||
| exc, | ||
| ) | ||
|
|
||
| return ssl_context |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.