Fix getSound(), message_sound resolution on 1.21+#154
Open
tomtehtom wants to merge 1 commit intoAust1n46:masterfrom
Open
Fix getSound(), message_sound resolution on 1.21+#154tomtehtom wants to merge 1 commit intoAust1n46:masterfrom
tomtehtom wants to merge 1 commit intoAust1n46:masterfrom
Conversation
…aced sounds via Registry.SOUNDS with legacy enum fallback. Previously only attempted enum resolution, causing all valid namespaced sounds to be rejected as invalid on 1.21+, both legacy wouldn't exist and new ones wouldn't parse. Fallback was always being applied for every input other than "None"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed message_sound config with resolving namespaced sounds via Registry.SOUNDS with legacy enum fallback.
Previously only attempted enum resolution, causing all valid new namespaced sounds to be rejected as invalid on 1.21+, both legacy wouldn't exist on this version and new ones wouldn't parse.
Fallback was always being applied for every input other than "None"