Add new permission and bypass for message toggle#9
Open
AjMaacc wants to merge 3 commits intoAust1n46:v4.0.0-stablefrom
Open
Add new permission and bypass for message toggle#9AjMaacc wants to merge 3 commits intoAust1n46:v4.0.0-stablefrom
AjMaacc wants to merge 3 commits intoAust1n46:v4.0.0-stablefrom
Conversation
AjMaacc
changed the title
Owner
|
The code you wrote does not match the feature you described. The permissions check should be applied as an additional condition to the existing if statement that checks messageToggle status. You'd also need to update the BungeeCord pluginMessage payload with the senders bypass flag to allow reading it on the receiving end in PluginMessageController. |
Aust1n46
requested changes
May 21, 2022
src/main/java/venture/Aust1n46/chat/initators/commands/Message.java
Outdated
Show resolved
Hide resolved
….java Co-authored-by: Aust1n46 <aust1n46@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an extra permissions check on the sender. If the sender has the permission
venturechat.messagetoggle.bypass, then they'll be able to bypass the message toggle feature if the receiver has it enabled and allow them to message the specified player.