Using LinkedIn URL lib to detect links properly#93
Open
joshi1999 wants to merge 6 commits intoAust1n46:masterfrom
Open
Using LinkedIn URL lib to detect links properly#93joshi1999 wants to merge 6 commits intoAust1n46:masterfrom
joshi1999 wants to merge 6 commits intoAust1n46:masterfrom
Conversation
update ProtocolLib, so it's compiling again.
use correct url-detector lib update ProtocolLib, so it's compiling again.
I don't know why intellij generates it in th first place, but all the methods of the bug tracker are outdated.
Fix wrongly overwriting every formatting code with the last one, even if they should work together like bold and underlined. Note: As per Minecraft's custom colour codes overwrite all formatting!
Made UrlDetector work with color codes.
|
This does now work with color codes at every part of the url. This makes this PR more flexible with the formatting codes than #123 as well as more robust detecting of urls in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.