Open
Conversation
Style caching was a precaution, in order to reset the styles to their previous values
before calling the Antiscroll constructor.
Now, this will not work anymore:
var containers = $('.container');
containers.find('.antiscroll-inner').css('background', 'red');
// The background is red
containers.antiscroll();
containers.each(function(){
$(this).data('antiscroll').rebuild();
});
// The red background is removed
But if we assume that:
- It is an expensive operation
- <div class="antiscroll-inner"> is supposed to be dedicated to
antiscroll
- Styles can still be added between the calls to antiscroll() and
rebuild(), and will not be cached
It’s relatively safe to remove it.
Add initialDisplay option. Fixes Automattic#8.
- updated demo to reflect changes - updated jquery to 1.7 because of this bug http://stackoverflow.com/questions/7825448/webkit-issues-with-event-layerx-and-event-layery
refresh scrollbars
Add a rebuild() method
improvement options parameter
If scrollbar size is 0 we were computing it every time scrollbarSize was called. It's especially wastefull on webkit browsers were scrollbar size can be set to 0 through CSS.
Optimize scrollbar size computing
Hard to see scrollbar when using darker background color.
…d Digital Color meter, and they are the exact same f'n color!
I noticed the shade of the scrollbars was a hair off native....
@guille, I measured the hover color, 0.04 alpha off. LOLZ
Set this.horizontal and this.vertical properties to null when destroyed and unbound scroll and mousewheel event listeners tied to the scrollbar when it is destroyed.
autoHide options (which defaults to true)
Conflicts: antiscroll.js
Conflicts: antiscroll.js
Conflicts: antiscroll.js
* Coding style fixes * options.Force refactoring
Conflicts: antiscroll.js
…uest Conflicts: antiscroll.js
Antiscroll stopped working properly in Chrome v25 (it's still in dev channel). For some reason native scrollbars are displayed under the antiscroll generated scrollbars. The browser behaves as if ::scrollbar pseudo class styles (setting scrollbar width/height to 0) were ignored. I am not really sure what's causing that, but when trying to investigate the problem I realized that scrollbarSize did not work properly in Chrome. It was returning 0 and not the native scrollbar width. We now calculate the size in the container with 'antiscroll-inner' class applied. If ::scrollbar CSS is applied properly the width is 0, and we don't have to hide native scrollbars manually. Otherwise scrollbars are hidden by adjusting .antiscroll-inner size. That fixes Chrome v25 issue.
Explaining Installation and Configuration
A lot of fixes and improvements
* Contributors update
antiscroll does not work with chrome Version 25.0.1323.1 dev
A bug in Chrome 25 on Lion requires each selector to have their own blocks. E.g. the following:
.antiscroll-inner::-webkit-scrollbar, .antiscroll-inner::scrollbar {...}
causes the width and height rules to be ignored by the browser resulting in both native and antiscroll scrollbars appearing at the same time.
Contributor
Author
|
Ping again @guille - demo page still showing the double scrollbars. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update demo page #46