Pin nokogiri >= 1.19.3 (GHSA-c4rq-3m3g-8wgx)#1807
Merged
Merged
Conversation
Carries the fix for [GHSA-c4rq-3m3g-8wgx][advisory] (high-severity ReDoS in Nokogiri's CSS selector tokenizer; vulnerable `< 1.19.3`). This repo is on `fastlane-plugin-wpmreleasetoolkit ~> 13.8`, which predates the toolkit's own `nokogiri >= 1.19.3` floor (added in 14.4.1). Pinning explicitly here closes the gap until a future toolkit-major bump makes the pin redundant. [advisory]: GHSA-c4rq-3m3g-8wgx --- Generated with the help of Claude Code, https://claude.com/claude-code Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mokagio
added
the
tooling
Contributor
There was a problem hiding this comment.
Pull request overview
This PR mitigates GHSA-c4rq-3m3g-8wgx by explicitly pinning Nokogiri to a non-vulnerable version in this repo’s Bundler setup, independent of the older fastlane-plugin-wpmreleasetoolkit constraint.
Changes:
- Add an explicit
nokogiri >= 1.19.3dependency to theGemfile. - Update
Gemfile.lockto resolve Nokogiri to1.19.3and record the new direct dependency.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Gemfile | Adds an explicit Nokogiri version floor to ensure the security fix is pulled in. |
| Gemfile.lock | Locks Nokogiri to 1.19.3 and includes Nokogiri in direct dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
iangmaia
approved these changes
May 11, 2026
Contributor
Author
|
Mmm... what's up with CI I wonder 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an explicit
gem 'nokogiri', '>= 1.19.3'pin toGemfileto pull in the fix for GHSA-c4rq-3m3g-8wgx — a high-severity ReDoS in Nokogiri's CSS selector tokenizer (vulnerable< 1.19.3).This repo is on
fastlane-plugin-wpmreleasetoolkit ~> 13.8, which predates the toolkit's ownnokogiri >= 1.19.3floor (added in 14.4.1). Pinning explicitly here closes the gap without requiring a release-toolkit major bump.Generated as part of the nokogiri 1.19.3 Orchard campaign covering all release-toolkit consumers.
Testing
bundle install.Gemfile.lockresolvesnokogirito1.19.3.Posted by Claude Code (Opus 4.7) on behalf of @mokagio with approval.