Fix infinite scroll bugs: clickable items and page reload #2523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix items becoming unclickable during page loading by removing isLoadingMore from DataViews isLoading prop. Items on page 1 now remain clickable while page 2+ is loading. - Fix page reload behavior for infinite scroll by not persisting the paged URL parameter when infinite scroll is enabled. Reloading now always starts from page 1, following standard infinite scroll UX. - Fix selection cleanup to check allLoadedRecords instead of feed to prevent premature selection clearing during page transitions. - Remove actor switching effect that was causing infinite update loop due to normalizedView creating new object references on every render.
github-actions
bot
added
[Focus] Editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two critical bugs in the infinite scroll implementation for the social-web feed while eliminating an infinite update loop.
Changes
isLoadingMorefrom DataViewsisLoadingprop so items on page 1 remain clickable while page 2+ is loadingpagedURL parameter when infinite scroll is enabled, ensuring reloads always start from page 1 (standard infinite scroll UX)allLoadedRecordsinstead offeedto prevent premature selection clearing during page transitionsnormalizedViewcreating new object references on every renderKnown Issue
The actor switching state cleanup (Bug 1) has been removed to prevent the infinite loop. This will need to be addressed next with a different approach that doesn't trigger the loop.
Test Plan