Fix reply block showing empty div when embed fails #2571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a post has `embedPost: true` but both oEmbed and the ActivityPub fallback fail (e.g., 401 for deleted/private posts), the reply block now shows a fallback link instead of an empty div. The fix initializes `$embed` to null before the conditional block and changes the condition from `if ( ! $show_embed )` to `if ( ! $show_embed || ! $embed )` so the fallback link displays when either embed is not requested OR when the embed attempt failed.
github-actions
bot
added
the
[Focus] Editor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the ActivityPub reply block would display an empty <div> element when oEmbed requests fail, by ensuring the fallback link is shown instead.
Key Changes:
- Modified the reply block rendering logic to check if the embed actually succeeded before deciding whether to show the fallback link
- Added explicit initialization of the
$embedvariable to track embed success
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| includes/class-blocks.php | Fixed conditional logic to show fallback link when embed fails and initialized $embed variable |
| .github/changelog/2571-from-description | Added changelog entry documenting the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pfefferle
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://wordpress.org/support/topic/import-mastodon-beta/
Proposed changes:
<div>when oEmbed fails by showing fallback link insteadOther information:
Testing instructions:
activitypub/replyblock pointing to a URL that has no oEmbed support and returns an error for ActivityPub requests (e.g.,https://obenland.it/404)Changelog entry
Changelog Entry Details
Significance
Type
Message
Reply block now shows fallback link when oEmbed fails instead of empty div.