APIGOV-31809 metrics min, max, avg preserving#1020
Merged
jcollins-axway merged 5 commits intomainfrom Apr 1, 2026
Merged
Conversation
alrosca
requested review from
dfeldick,
dgghinea,
jcollins-axway,
sbolosan and
vivekschauhan
as code owners
sbolosan
reviewed
Mar 26, 2026
sbolosan
reviewed
Mar 26, 2026
Collaborator
|
In general, can we add inline comments and some tests for this. We can take advantage of the logging I captured in the first pass and run those examples through the tests. |
jcollins-axway
requested changes
Mar 26, 2026
Collaborator
jcollins-axway
left a comment
jcollins-axway
left a comment
There was a problem hiding this comment.
Could we add some unit tests around this and validate the min, max, average with various counts?
Collaborator
You could pull in the logging content from the parent ticket that actually has the real values to put through the unit tests |
sbolosan
reviewed
Mar 27, 2026
sbolosan
approved these changes
Mar 27, 2026
jcollins-axway
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.