Skip to content

Quantum: workspace create and set related bug fixes#9906

Merged
necusjz merged 2 commits into
Azure:mainfrom
rigidit:users/rigidit/quantum-bugfixes
May 29, 2026
Merged

Quantum: workspace create and set related bug fixes#9906
necusjz merged 2 commits into
Azure:mainfrom
rigidit:users/rigidit/quantum-bugfixes

Conversation

@rigidit
Copy link
Copy Markdown
Contributor

@rigidit rigidit commented May 29, 2026

Description:

  • Fixed bug where workspace providers were appended to wrong property causing workspace creation to fail
  • Improved error handling for az quantum workspace set to provide a clear error message when a workspace is not yet fully provisioned
  • Added timeout after workspace creation in e2e test

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings May 29, 2026 00:02
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented May 29, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented May 29, 2026

Quantum

@necusjz necusjz merged commit f561f26 into Azure:main May 29, 2026
32 checks passed
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ quantum-1.0.0b15 ] : https://dev.azure.com/msazure/One/_build/results?buildId=165988604&view=results

s-ddavydenko pushed a commit to s-ddavydenko/azure-cli-extensions that referenced this pull request May 29, 2026
* Fix workspace create, tested

* Worspace set command improvements
necusjz pushed a commit that referenced this pull request Jun 2, 2026
* remove dpericated --location

* style

* update history

* NetworkCloud CLI for the 2026-05-01-preview API (#9867)

* Managed Network Fabric CLI updates for new 2026-01-15-preview API

* Managed Network Fabric CLI updates for new 2026-01-15-preview API

* NetworkCloud CLI for the 2026-05-01-preview API

* NetworkCloud CLI for the 2026-05-01-preview API

* retrigger checks

* [Release] Update index.json for extension [ networkcloud-5.0.0b2 ]

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=165822620&view=results

Last commit: 72ddb7f

* Quantum: workspace create and set related bug fixes (#9906)

* Fix workspace create, tested

* Worspace set command improvements

* [Release] Update index.json for extension [ quantum-1.0.0b15 ]

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=165988604&view=results

Last commit: f561f26

* [Microsoft.ChangeSafety][BugFix] fix additional data parsing issue (#9901)

* Fix --additional-data and --change-definition to accept free-form nested JSON

The --additional-data argument was defined as AAZObjectArg with no child
fields, causing 'Model AAZObjectArg has no field named safeFly' errors.
The --change-definition details field had the same issue, rejecting
ApiOperations payloads with 'no field named operations'.

Changes:
- Change additional_data from AAZObjectArg to AAZFreeFormDictArg
- Change change_definition.details from AAZObjectArg to AAZFreeFormDictArg
- Change corresponding AAZObjectType to AAZFreeFormDictType in builders
  and response schemas across create, update, show, and list
- Add content injection for additionalData in custom.py (same pattern as
  changeDefinition) to work around AAZ builder serialization limitation
- Add tests for SafeFly payload, links, and orchestration-tool arguments
- Bump version to 1.0.0b2

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Retrigger CI (transient GitHub 403 incident on prior run)

* Address PR nits: use 'is None' / 'is not None' for additional_data checks

Per review feedback, replace truthiness checks with explicit None checks so
that an explicitly provided empty dict {} is treated as a valid user-supplied
value rather than being silently dropped.

- _inject_additional_data_into_content: 'if not additional_data' -> 'is None'
- ChangeRecordCreate.pre_operations: 'if additional_data' -> 'is not None'
- ChangeRecordUpdate.pre_operations: same fix for consistency (duplicated pattern)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Henry Dai <henrydai@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [Release] Update index.json for extension [ azure-changesafety-1.0.0b2 ]

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/msazure/One/_build/results?buildId=166044594&view=results

Last commit: b145cb5

* style

* history log

* delete empty breaking_changes file

* version bump in setup.py

---------

Co-authored-by: idanielsteven <danielsteven@microsoft.com>
Co-authored-by: Azure CLI Team <AzPyCLI@microsoft.com>
Co-authored-by: Zulfat Nutfullin <rigidit@users.noreply.github.com>
Co-authored-by: likesys <henry.zekun.dai@outlook.com>
Co-authored-by: Henry Dai <henrydai@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants