Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 27, 2026

Adds automated shellcheck linting on PRs that modify shell scripts, surfacing errors as GitHub Checks annotations.

Changes

  • New workflow: .github/workflows/shellcheck.yml
    • Triggers on .sh file changes in PRs to main
    • Uses reviewdog/action-shellcheck@v1 with github-check reporter for inline annotations
    • Scans all shell scripts with info-level reporting
    • Includes concurrency control to cancel stale runs

Implementation Details

  • Permissions: checks: write added for annotation support
  • No conflicts: Verified shellcheck not used elsewhere in workflows or pipelines (27 shell scripts across cli/installer, extensions, eng/scripts)
  • Pattern matching: "*.sh" covers all shell scripts recursively
- name: Run ShellCheck
  uses: reviewdog/action-shellcheck@v1
  with:
    github_token: ${{ secrets.GITHUB_TOKEN }}
    reporter: github-check
    path: "."
    pattern: "*.sh"
    level: info
Original prompt

This section details on the original issue you should resolve

<issue_title>[EngSys] Add GitHub Action that runs shellcheck on PRs that change .sh files</issue_title>
<issue_description>Surface errors in file tab using GitHub Actions annotations</issue_description>

<agent_instructions>Make sure that shellcheck isn't used anywhere else in DevOps pipelines or workflows. If it is we'll have to rethink.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits January 27, 2026 19:20
Co-authored-by: danieljurek <2158838+danieljurek@users.noreply.github.com>
Co-authored-by: danieljurek <2158838+danieljurek@users.noreply.github.com>
Copilot AI changed the title [WIP] Add GitHub Action to run shellcheck on .sh files Add shellcheck GitHub Action with annotations for .sh files Jan 27, 2026
Copilot AI requested a review from danieljurek January 27, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EngSys] Add GitHub Action that runs shellcheck on PRs that change .sh files

2 participants