Telemetry dev branch cleanup #1206
Open
+154
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 files - 62 61 suites - 2 1m 27s ⏱️ - 57m 11s Results for commit a7f5281. ± Comparison against base commit 206c1a3. This pull request removes 8 and adds 1000 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
MariusNi
reviewed
Nov 14, 2025
MariusNi
reviewed
Nov 14, 2025
simonjaeger
approved these changes
Nov 15, 2025
MariusNi
reviewed
Nov 15, 2025
| wget \ | ||
| zip | ||
|
|
||
| mkdir -p ~/git && cd ~/git |
Contributor
There was a problem hiding this comment.
Why is this necessary? This is not a dependency - it is an additional build step, why do we need it?
MariusNi
reviewed
Nov 15, 2025
README.md
Outdated
|
|
||
| # Clone/Build/Install CMake 3.21.7 | ||
| git clone https://github.com/Kitware/CMake --recursive -b v3.21.7 | ||
| cd CMake && ./bootstrap && make -j$(nproc) && make install && hash -r && rm -rf /git/CMake |
Contributor
There was a problem hiding this comment.
This step fails for me with this error:
[100%] Built target foo
Install the project...
-- Install configuration: "Release"
CMake Error at Source/kwsys/cmake_install.cmake:46 (file):
file cannot create directory: /usr/local/doc/cmake-3.21/cmsys. Maybe need
administrative privileges.
Call Stack (most recent call first):
cmake_install.cmake:47 (include)
make: *** [Makefile:144: install] Error 1
MariusNi
reviewed
Nov 15, 2025
| mkdir -p ~/git && cd ~/git | ||
|
|
||
| # Clone/Build/Install CMake 3.21.7 | ||
| git clone https://github.com/Kitware/CMake --recursive -b v3.21.7 |
Contributor
There was a problem hiding this comment.
Why cannot we install a regular CMake, why have to locally build it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
devbranch prior to this PR submission.devbranch.