Skip to content

Conversation

@gracewilcox
Copy link
Member

module currently failing in the pipeline, updating to remove linting issues

@github-actions github-actions bot added the Monitor Monitor, Monitor Ingestion, Monitor Query label Dec 2, 2025
@gracewilcox gracewilcox marked this pull request as ready for review December 2, 2025 23:13
@gracewilcox gracewilcox requested review from a team, chlowell and jhendrixMSFT as code owners December 2, 2025 23:13
Copilot AI review requested due to automatic review settings December 2, 2025 23:13
@gracewilcox gracewilcox requested a review from a team as a code owner December 2, 2025 23:13
Copilot finished reviewing on behalf of gracewilcox December 2, 2025 23:15
@gracewilcox gracewilcox merged commit 484c0d8 into Azure:main Dec 2, 2025
30 of 31 checks passed
@gracewilcox gracewilcox deleted the azquery-lint branch December 2, 2025 23:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes incorrect field access patterns for embedded structs in the azquery module that were causing lint failures in the pipeline.

Key changes:

  • Fixed embedded struct field access in test and example code by removing redundant intermediate struct names
  • Updated res.Response.Timespan to res.Timespan (and similar fields) in metrics tests
  • Updated res.BatchResponse.Responses to res.Responses in batch query examples

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sdk/monitor/azquery/metrics_client_test.go Corrected field access patterns for MetricsClientQueryResourceResponse to use promoted fields from embedded Response struct
sdk/monitor/azquery/example_test.go Corrected field access pattern for LogsClientQueryBatchResponse to use promoted field from embedded BatchResponse struct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Monitor Monitor, Monitor Ingestion, Monitor Query

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants