Skip to content

Comments

[eno] Adding logic for force cleanup composition#564

Merged
ruinan-liu merged 6 commits intomainfrom
users/ruinanliu/fix-composition-stuck
Feb 19, 2026
Merged

[eno] Adding logic for force cleanup composition#564
ruinan-liu merged 6 commits intomainfrom
users/ruinanliu/fix-composition-stuck

Conversation

@ruinan-liu
Copy link
Contributor

@ruinan-liu ruinan-liu commented Feb 13, 2026

we will force remove a finalizer of a composition if and only if

  1. The composition has label "aks.azure.com/component-type":addon or the composition has label "eno.azure.io/overlaymgr-component-type":addon AND
  2. the owner symphony is gone.

@ruinan-liu ruinan-liu marked this pull request as ready for review February 13, 2026 23:22
Copy link
Contributor Author

@ruinan-liu ruinan-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replied to comment

Copy link
Contributor Author

@ruinan-liu ruinan-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reply to comments

Copy link
Contributor Author

@ruinan-liu ruinan-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replied to comment

@ruinan-liu ruinan-liu requested a review from xiazhan February 18, 2026 21:37
Copy link
Contributor Author

@ruinan-liu ruinan-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the code

Copy link
Contributor Author

@ruinan-liu ruinan-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replied to comment

Copy link
Contributor Author

@ruinan-liu ruinan-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix code

Copy link
Contributor Author

@ruinan-liu ruinan-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

respond to comment

@ruinan-liu ruinan-liu merged commit 5ed331d into main Feb 19, 2026
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants