Conversation
…tor (bragg and gap motors only), and support for new multi-system transfocator IOC
Contributor
|
Running |
Contributor
|
Finding: None of this code is tested (except for style). That is to say, there are no unit tests intended to test any of this code. |
Contributor
|
With pre-commit, new code does not trigger any unit test failures. Would you mind revising the code to follow PEP8: capitalize all class names? |
Collaborator
Author
Will do. |
prjemian
approved these changes
May 13, 2026
Contributor
prjemian
left a comment
prjemian
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for new multi-system transfocator (CRLs) iocs. These new IOCS will be in use at 8ID, 9ID, 12ID, and 28ID. The old transfocator (jj_transfocators) support should still be used at 4ID and 6ID who are using older EPICS support for their transfocators (both are single CRL systems)
Bluesky support for new mono support for mono's using only bragg and gap motors (instead of the bragg, z-slide, y-slide found in the Kohzu support). The EPICS support is meant for the newer monos from IDT (in use at 8ID and 9ID among other beamlines).