Skip to content

Conversation

@msadiqaadil
Copy link
Collaborator

Updated various libraries.
Updated the minimum deployment target to 17.0.

@msadiqaadil msadiqaadil requested review from a team and burgbart as code owners September 23, 2025 07:51
tibor-is-back
tibor-is-back previously approved these changes Sep 24, 2025
@tibor-is-back tibor-is-back dismissed their stale review September 24, 2025 13:15

Spotted something


func appendCustomHeader() {
if let defaultHTTPHeaders = Backbase.configuration().custom["default-http-headers"] as? [String: String] {
if let defaultHTTPHeaders = Backbase.configuration().persistentHeaders["default-http-headers"] as? [String: String] {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the aforementioned constants for it.


install! 'cocoapods', deterministic_uuids: false
source 'https://cdn.cocoapods.org/'
source 'https://repo.backbase.com/artifactory/api/pods/pods'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including artifactory is the standard pattern that I believe we've aligned on.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed!

@tibor-is-back tibor-is-back merged commit 0b22097 into main Sep 26, 2025
3 of 4 checks passed
@tibor-is-back tibor-is-back deleted the chore/MF-2373-Update-Golden-Sample-App branch September 26, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants