-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Pocket Device Support #3372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yconst
wants to merge
5
commits into
BasedHardware:main
Choose a base branch
from
yconst:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,914
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
if the raw codec of pocket is mp3, i’d like to support it on the backend side. currently, we have supported: opus, lc3, aac, pcm fyi. |
- Add PocketDeviceConnection with battery polling and storage info - Implement Pocket recordings UI with download functionality - Add device type detection for Pocket devices (PKT01 prefix) - Fix device type persistence for Pocket devices - Add null safety improvements for device locator - Display storage in GB and battery level correctly - Sequential loading: device info then recordings list
- Add PocketWalService to create WAL files from Pocket MP3 recordings - Implement download and sync flow in PocketDevicePage - Add 'pocket' to ConversationSource enum for tagging - Add MP3 converter service (prepared for future client-side conversion) - Add audioplayers dependency
- Fix WAL storage to use disk storage instead of sdcard - Add initializeWals() public method to reload WALs after saving - Force reload WALs in phone sync service after adding Pocket recordings - Add DeviceType.pocket case to device image switch - WALs now appear correctly in Sync page after download
- Add complete Pocket device integration with BLE communication - Add Pocket MP3 download and WAL sync service - Add Pocket recordings UI page - Add ConversationSource.pocket enum value - Fix: Skip discard check for Pocket recordings (user-initiated) - Add pocket router endpoint for MP3 uploads - Add Pocket device models and connection handling - Update device detection and provider for Pocket support
Collaborator
|
@yconst is this ready? |
Author
Yeap, it is ready |
Author
I added backend support for mp3 codec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Pocket Device Support
Overview
Implements complete Pocket device support with MP3 recording download, backend processing, and fixes a bug where Pocket recordings were being incorrectly discarded.
What's New
Frontend:
Backend:
/v1/pocket/upload-mp3endpointpockettoConversationSourceenumBug Fix 🐛
Fixed: Pocket recordings being discarded
ConversationSource.pocketHow It Works
Files Changed
21 files changed, 1741 insertions(+), 18 deletions(-)
Key new files:
app/lib/pages/pocket/pocket_device_page.dart- Pocket recordings UIapp/lib/services/devices/pocket_connection.dart- BLE protocolbackend/routers/pocket.py- MP3 processing endpointTesting
✅ Fully tested end-to-end with physical Pocket device (PKT01_BLUE)
Test: Connect Pocket device → Download recordings → Verify conversations appear in main feed
Breaking Changes
None - purely additive feature