refactor indicator drawing and storage code to facilitate per-pixel access#812
Open
usuallyannoyed wants to merge 1 commit intoBlueforcer:mainfrom
Open
refactor indicator drawing and storage code to facilitate per-pixel access#812usuallyannoyed wants to merge 1 commit intoBlueforcer:mainfrom
usuallyannoyed wants to merge 1 commit intoBlueforcer:mainfrom
Conversation
…etting, in preparation for expanding the external-facing API
Contributor
|
I would suggest to make the Indicator a member of the DisplayManager, so we keep all display related API in this class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick refactoring of the code for the three on-screen indicators. In addition to a little cleanup to simplify the code, exposes the ability to set all parameters (color, fade, blink, state, etc.) on a per-pixel level. For now this does nothing to the overall functionality and does not break any code that uses the indicators. However, it now enables the MQTT to be expanded to enable per-pixel settings for more customizability when desired.