-
Notifications
You must be signed in to change notification settings - Fork 5
Typescript iteration - TS 5.8 and isolated declarations! #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9d16346:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'benchmarkjs, node 22'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: 8cc3770 | Previous: 32cd707 | Ratio |
|---|---|---|---|
create empty, size: 2e6 |
2967 ops/sec (±6.99%) |
3285 ops/sec (±6.06%) |
1.11 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @Bnaya
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
benchmarkjs, node 20
Details
| Benchmark suite | Current: 9d16346 | Previous: 8cc3770 | Ratio |
|---|---|---|---|
create empty, size: 2e6 |
2223 ops/sec (±3.92%) |
1993 ops/sec (±3.91%) |
0.90 |
create with 2500 comments. size: 2e6 |
153 ops/sec (±4.51%) |
143 ops/sec (±5.22%) |
0.93 |
save 2500 comments into pre-created OB, size: 2e6 |
160 ops/sec (±1.65%) |
148 ops/sec (±1.84%) |
0.93 |
create with all mock data rows. size: 2e6 |
155 ops/sec (±5.10%) |
140 ops/sec (±5.43%) |
0.90 |
A-Z object keys |
41996 ops/sec (±0.44%) |
39562 ops/sec (±0.49%) |
0.94 |
A-Z object prop Lookup in operator - non-existing |
14052597 ops/sec (±0.21%) |
13948953 ops/sec (±0.34%) |
0.99 |
A-Z object prop Lookup in operator - existing |
2828752 ops/sec (±0.39%) |
2866103 ops/sec (±0.29%) |
1.01 |
A-Z object prop access T |
2799330 ops/sec (±0.22%) |
2750562 ops/sec (±0.27%) |
0.98 |
A-Z object prop access Z |
2720528 ops/sec (±2.74%) |
2737612 ops/sec (±0.31%) |
1.01 |
OB_WITH_NA2Z_KEYS object keys |
27151 ops/sec (±0.42%) |
25540 ops/sec (±0.33%) |
0.94 |
OB_WITH_NA2Z_KEYS object prop Lookup in operator - non-existing |
1790073 ops/sec (±0.13%) |
1685050 ops/sec (±1.74%) |
0.94 |
OB_WITH_NA2Z_KEYS object prop Lookup in operator - existing |
1767861 ops/sec (±0.22%) |
1674374 ops/sec (±0.24%) |
0.95 |
OB_WITH_NA2Z_KEYS object prop access 14ABCDEFGHIJKLMNOPQRSTUVWXYZ |
1700453 ops/sec (±0.20%) |
1693608 ops/sec (±0.20%) |
1.00 |
OB_WITH_NA2Z_KEYS object prop access 3ABCDEFGHIJKLMNOPQRSTUVWXYZ |
1714750 ops/sec (±0.20%) |
1690128 ops/sec (±1.86%) |
0.99 |
Array access. length: 1000 |
4097769 ops/sec (±0.34%) |
4083112 ops/sec (±0.27%) |
1.00 |
object memory free. K1000RowsMockData, pre-created OB, size: 2e6 |
17.74 ops/sec (±1.05%) |
17.09 ops/sec (±0.64%) |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'benchmarkjs, node 20'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: 8cc3770 | Previous: 32cd707 | Ratio |
|---|---|---|---|
create empty, size: 2e6 |
1993 ops/sec (±3.91%) |
2355 ops/sec (±4.37%) |
1.18 |
create with all mock data rows. size: 2e6 |
140 ops/sec (±5.43%) |
156 ops/sec (±4.42%) |
1.11 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @Bnaya
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'benchmarkjs, node 24'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: 9d16346 | Previous: 8cc3770 | Ratio |
|---|---|---|---|
create empty, size: 2e6 |
3618 ops/sec (±7.58%) |
4062 ops/sec (±6.51%) |
1.12 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @Bnaya
Bnaya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.