Skip to content

fix(seo): JSON-LD structured data and sitemap hostname #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabitoesmiapodo wants to merge 2 commits into
base: fix/performance
Choose a base branch
from
Open

fix(seo): JSON-LD structured data and sitemap hostname #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a37445c
fix(seo): add JSON-LD structured data and fix sitemap hostname
gabitoesmiapodo Mar 23, 2026
d0c83c8
fix(seo): use || instead of ?? for sitemap hostname fallback
gabitoesmiapodo Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,27 @@
<body>
<div id="root"></div>
<script type="module" src="/src/main.tsx"></script>
<script type="application/ld+json">
{
"@context": "https://schema.org",
"@graph": [
{
"@type": "Organization",
"name": "BootNode",
"url": "https://bootnode.dev",
"sameAs": ["https://twitter.com/bootnodedev"]
},
{
"@type": "WebApplication",
"name": "dAppBooster",
"url": "https://demo.dappbooster.dev/",
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSON-LD url values are hardcoded to bootnode.dev / demo.dappbooster.dev. If this app is deployed on a different hostname (now supported for the sitemap via PUBLIC_APP_URL), the structured data will advertise the wrong canonical URL. Consider deriving these URLs from the same configured base URL at build time (or otherwise ensuring they stay in sync with the deployment hostname).

Suggested change
"url": "https://demo.dappbooster.dev/",
"url": "/",

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

@gabitoesmiapodo gabitoesmiapodo Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not changing. JSON-LD @id and url values must be absolute IRIs — a relative / is invalid structured data. For a project template the static fallback URL is acceptable; deriving it from PUBLIC_APP_URL at build time is a future enhancement.

"description": "A modern blockchain boilerplate built to quickly get you started with the development of your next Web3 project.",
"applicationCategory": "DeveloperApplication",
"operatingSystem": "Web"
}
]
}
</script>
</body>

</html>
2 changes: 1 addition & 1 deletion vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default defineConfig({
react(),
tsconfigPaths(),
Sitemap({
hostname: 'https://dappbooster.dev',
hostname: process.env.PUBLIC_APP_URL || 'https://demo.dappbooster.dev',
}),
Comment on lines 16 to 18
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

process.env.PUBLIC_APP_URL ?? ... will treat the common empty-string value (see .env.example sets PUBLIC_APP_URL='') as a valid hostname, resulting in an empty hostname and an invalid sitemap. Also, relying on process.env here may miss values from Vite’s .env loading unless the variable is exported in the shell. Consider loading env via Vite’s loadEnv in defineConfig(({ mode }) => ...) and normalizing to a non-empty URL origin (e.g., trim + parse + fallback).

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

@gabitoesmiapodo gabitoesmiapodo Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: changed ?? to || in the previous round so an empty string falls through to the hardcoded default.

],
build: {
Expand Down
Loading