Upgrade libraries and remove jQuery functions#375
Upgrade libraries and remove jQuery functions#375beradrian wants to merge 3 commits intoBorisMoore:masterfrom
Conversation
|
I'm not sure if there is an issue with the current implementation of isArray and isFunction? If jQuery is loaded, then the jQuery versions are used. I jQuery is not loaded then they are implemented in jsrender.js. Note too that jsrender.js can be loaded with jquery.observable.js and jquery.views.js - both of which need also to access those functions. (Similarly for jsviews.js, which is in effect a composite of the three separate files.) |
|
isArray and isFunction were deprecated in jquery3 and if you have jquery-migrate you would see these warnings |
|
Ah, makes sense. Thanks. I will make corresponding changes for the next update of JsRender and JsViews. Because of the way JsRender and JsViews are built, I will need to make the changes in the jsviews.com repository, and then 'propogate' the changes to jsrender.js, jquery,views.js, jquery.observable.js, and jsviews.js, through the build process. So I won't actually merge your PR. |
Several minor bug fixes, in JsRender, JsViews and JsViews.com: BorisMoore/jsrender#374 Prevent prototype pollution attacks BorisMoore/jsviews#469 Data binding does not work on contenteditable="plaintext-only" BorisMoore/jsviews#468 View Model data mapping: JSON.parse inconsistency BorisMoore/jsviews#466 View Model 'sort' not working BorisMoore/jsviews#465 Checkboxgroup, usage without linked value first defined BorisMoore/jsviews#464 Minor 'View Model' conditional issue & data-link with () or without BorisMoore/jsviews#463 Checkboxgroup issue when used with View Model BorisMoore/jsviews#461 <Input required... WITH rendered output BorisMoore/jsrender#375 isArray and isFunction switch to using native implentations, instead of deprecated jQuery versions.
Several minor bug fixes, in JsRender, JsViews and JsViews.com: #374 Prevent prototype pollution attacks BorisMoore/jsviews#468 View Model data mapping: JSON.parse inconsistency BorisMoore/jsviews#466 View Model 'sort' not working BorisMoore/jsviews#463 Checkboxgroup issue when used with View Model #375 isArray and isFunction switch to using native implentations, instead of deprecated jQuery versions.
Several minor bug fixes, in JsRender, JsViews and JsViews.com: BorisMoore/jsrender#374 Prevent prototype pollution attacks #469 Data binding does not work on contenteditable="plaintext-only" #468 View Model data mapping: JSON.parse inconsistency #466 View Model 'sort' not working #465 Checkboxgroup, usage without linked value first defined #464 Minor 'View Model' conditional issue & data-link with () or without #463 Checkboxgroup issue when used with View Model #461 <Input required... WITH rendered output BorisMoore/jsrender#375 isArray and isFunction switch to using native implentations, instead of deprecated jQuery versions.
2 participants
No description provided.