Draft
Conversation
Contributor
|
Hi Christian, I think this is a great addition. |
Contributor
Author
|
I think the safest thing would be to setup a bunch of tests related to this. However, I think that would require a lot of work to verify that things like this work. There are options to make the formatter do only safe changes to the code, therefore it wouldn't do something like change def f(a = []): pass # unsafe because every call to `f` would refer to the same listinto def f(a=None):
if a is None:
a = [] # safe because the list gets assigned when the function is called and not when the function is defined
passThere is more that I would like to test out before making the plunge on this but having a formatter/linter seems like it would be useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the code to improve readability and removed unnecessary variables and expressions. Fixed incorrect variable references and organized imports and adjusted white space. This pull request aims to improve the overall code quality and maintainability.
Moving forward, we can use
ruffto both lint and format our code.@AlvaroS, can you give your thoughts on this