Reclassify Freezer as Equipment#640
Open
connorjcantrell wants to merge 1 commit intoBrickSchema:masterfrom
Open
Reclassify Freezer as Equipment#640connorjcantrell wants to merge 1 commit intoBrickSchema:masterfrom
connorjcantrell wants to merge 1 commit intoBrickSchema:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A freezer's composition typically includes a compressor, metering device, condenser coil, evaporator coil, and defrost system, all of which serve a compartment of varying sizes depending on its application. It is designed to maintain this compartment at sub-freezing temperatures. While I understand the perspective of classifying the compartment as a brick:Space, this disregards the core components of a freezer that perform the work of maintaining the desired temperature.
Since a freezer's primary function is to maintain the necessary sub-freezing environment. Classifying it as brick:Equipment is most appropriate to distinguish it from "passive" spaces. Therefore, I propose reclassifying brick:Freezer as brick:Equipment rather than brick:Room.
Additionally, I see the perspective of classifying a Walk-in Freezer/Cooler as both brick:Equipment and brick:Space. However, since these also perform active work to maintain specific temperatures, I would prefer to classify them as brick:Equipment. With that being said, perhaps there's room to consider a class, such as Walk-in Freezer, which is both type equipment and space.