Skip to content

fix: fallback for empty model list #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
euyua9 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fallback for empty model list #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions src/helpers/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,22 @@ const languagesOptions = Object.entries(i18n.languages).map(([key, value]) => ({
label: value,
}));

const getModelOptions = (models: Model[]) =>
models
.map((model) => model.id)
.filter((id): id is string => typeof id === 'string' && id.length > 0)
.map((id) => ({ value: id, label: id }));

const promptForModelId = async () =>
p.text({
message: i18n.t('Enter the model id'),
validate: (value) => {
if (!value.length) {
return i18n.t('Please enter a model id');
}
},
});

const parseAssert = (name: string, condition: any, message: string) => {
if (!condition) {
throw new KnownError(
Expand Down Expand Up @@ -191,12 +207,15 @@ export const showConfigUI = async () => {
const { OPENAI_KEY: key, OPENAI_API_ENDPOINT: apiEndpoint } =
await getConfig();
const models = await getModels(key, apiEndpoint);
const model = (await p.select({
message: 'Pick a model.',
options: models.map((m: Model) => {
return { value: m.id, label: m.id };
}),
})) as string;
const modelOptions = getModelOptions(models);
const model = (
modelOptions.length > 0
? await p.select({
message: 'Pick a model.',
options: modelOptions,
})
: await promptForModelId()
) as string | symbol;

if (p.isCancel(model)) return;
await setConfigs([['MODEL', model]]);
Expand Down