Conversation
* Corrects the base85 alphabet. Previously it was only 83 distinct
characters: s/t were transposed, w was omitted, and _ appeared twice.
* Switches to a consistent invalid plaintext sentinel. Previously digit
-1 was rendered as any of {'.', ',', "'", ':', '-', '/', '[', ']',
'\\', 'w'} depending on the test, and digit 85 was rendered
as '\x7f' (a non-printable DEL). The updated vectors standardizes both
to '-' (which is not in the new alphabet, so it remains "invalid").
cpu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the fixed vectors offered by @dspdon in #239
s/twere transposed, w was omitted, and_appeared twice.-1was rendered inconsistently as one of 10 different out-of-alphabet characters(', ,, -, ., /, :, [, \, ], w), and digit 85 was rendered as\x7f(non-printable DEL). The updated vectors use-for both (which is not in the new alphabet, so the test cases remain invalid).I did a quick sanity pass on the other
aes_ff1_*testvectors and didn't spot any similar issues in their alphabets. Further review input welcome.Resolves #239