-
-
Notifications
You must be signed in to change notification settings - Fork 606
feat: combo bind (frontend) #6407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sqlerrorthing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow slow down bro
|
use a combo like "Shift + A" in the bind itself instead of mod buttons bottom of the bind |
|
What happend to the header?! |
|
I think it would be better if modifiers would be applied during press and not through an additional option. I mean, most applications allow you to have anything as a bind, so I don't really see why we would limit lb to an modifiers option? |
same. |
|
I'll try to do that later. One exisitng problem is the "Bind: XXX" button is not long enough to show something like "A+Shift+Ctrl+Alt" |
|
Simply scale the text down dynamically if it gets too big. This should be possible using CSS. |
|
oh, i see a few ways:
|
looks pretty good! hide & maybe mute the |
QQ2025713-22437.mp4 |
|
I think 2 lines in this situation is acceptable. |
but hide the name label. |
|
Because this pull request has commits from #6277 I will until until that pull request is merged. |
|
I will solve the conflicts today |
|
Resolved, but I need to adjust some styles of the value text. |
|
XD I will make the "Bind: " be combined eith following texts |
i have other idea. if there is enough space: otherwise: |
|
I'll edit some code when I'm at home. |
|
@MukjepScarlet please review my pr |
Please 🙏 do it in another pr (in ur repo) and mention me in this pr |
QQ2025715-214944.mp4 |
|
good! add aniamtion to the arrow like scale or smth move to right and back when clicking & hovering |
|
@MukjepScarlet what remains to do? |
|
Nothing |
|
good, put screenshots & videos into pr description |
|
@SenkJu we are orphans |
|
Waiting... |
|
|
@superblaubeere27, why u or just... @1zun4 cant review it? |
|
Needs to be merged with upstream. |
|
Needs permission to merge. @SenkJu |
|
... |
This comment was marked as spam.
This comment was marked as spam.
Co-authored-by: sqlerrorthing <[email protected]>
bc1a3e1 to
b365931
Compare
|
This will be merged before 1.21.10. |
|
㊗️ |




Allows you to use bind like Shift+Ctrl+R.
Showcase:
recording_2025-07-16_15.08.04.mp4
closes #6405
depends on #6277 (merged)