Skip to content

Conversation

@MukjepScarlet
Copy link
Contributor

@MukjepScarlet MukjepScarlet commented Jul 12, 2025

Allows you to use bind like Shift+Ctrl+R.

Showcase:

  • OSX icons:
image
recording_2025-07-16_15.08.04.mp4

closes #6405

depends on #6277 (merged)

Copy link
Contributor

@sqlerrorthing sqlerrorthing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow slow down bro

@MukjepScarlet
Copy link
Contributor Author

MukjepScarlet commented Jul 13, 2025

image

@1zun4 @sqlerrorthing

@sqlerrorthing
Copy link
Contributor

image

@1zun4 @sqlerrorthing

no :(

@sqlerrorthing
Copy link
Contributor

use a combo like "Shift + A" in the bind itself instead of mod buttons bottom of the bind

@1zun4
Copy link
Member

1zun4 commented Jul 13, 2025

What happend to the header?!

@1zun4
Copy link
Member

1zun4 commented Jul 13, 2025

I think it would be better if modifiers would be applied during press and not through an additional option. I mean, most applications allow you to have anything as a bind, so I don't really see why we would limit lb to an modifiers option?

@sqlerrorthing
Copy link
Contributor

I think it would be better if modifiers would be applied during press and not through an additional option.

same.

@MukjepScarlet
Copy link
Contributor Author

I'll try to do that later. One exisitng problem is the "Bind: XXX" button is not long enough to show something like "A+Shift+Ctrl+Alt"

@MukjepScarlet MukjepScarlet marked this pull request as draft July 13, 2025 07:37
@1zun4
Copy link
Member

1zun4 commented Jul 13, 2025

Simply scale the text down dynamically if it gets too big. This should be possible using CSS.

@sqlerrorthing
Copy link
Contributor

sqlerrorthing commented Jul 13, 2025

oh, i see a few ways:

  1. use dynamic font size.
  2. remove prefix Bind: , use tooltip instead.
  3. use both steps (1st n 2nd)

@MukjepScarlet
Copy link
Contributor Author

image Keep updating...

@sqlerrorthing
Copy link
Contributor

sqlerrorthing commented Jul 13, 2025

Keep updating...

looks pretty good! hide Bind: if there is no enough space

& maybe mute the +?

@MukjepScarlet MukjepScarlet marked this pull request as ready for review July 13, 2025 14:40
@MukjepScarlet
Copy link
Contributor Author

QQ2025713-22437.mp4

@MukjepScarlet MukjepScarlet requested a review from 1zun4 July 13, 2025 14:46
@sqlerrorthing
Copy link
Contributor

sqlerrorthing commented Jul 13, 2025

image

Also Shift + Control + Numpad 0 fits in 2 lines.

scale the text.

@MukjepScarlet
Copy link
Contributor Author

I think 2 lines in this situation is acceptable.

@sqlerrorthing
Copy link
Contributor

I think 2 lines in this situation is acceptable.

but hide the name label.

@1zun4
Copy link
Member

1zun4 commented Jul 13, 2025

Because this pull request has commits from #6277 I will until until that pull request is merged.

@MukjepScarlet
Copy link
Contributor Author

I will solve the conflicts today

@MukjepScarlet
Copy link
Contributor Author

Resolved, but I need to adjust some styles of the value text.

@sqlerrorthing
Copy link
Contributor

sqlerrorthing commented Jul 14, 2025

image

what idk how i do that

@MukjepScarlet
Copy link
Contributor Author

XD I will make the "Bind: " be combined eith following texts

@sqlerrorthing
Copy link
Contributor

sqlerrorthing commented Jul 14, 2025

XD I will make the "Bind: " be combined eith following texts

i have other idea.

if there is enough space:

+---------------------------------+
| Bind: Ctrl + Shift + A | Toggle |
+---------------------------------+
+---------------------------------+
| Bind: Ctrl + Shift + A   | Hold |
+---------------------------------+

otherwise:

+-------------------------------+
|            Bind:       Toggle |
| Ctrl + Shift + Alt + Numpad 0 |
+-------------------------------+
+-------------------------------+
|             Bind:        Hold |
| Ctrl + Shift + Alt + Numpad 0 |
+-------------------------------+

@MukjepScarlet
Copy link
Contributor Author

I'll edit some code when I'm at home.

@sqlerrorthing
Copy link
Contributor

@MukjepScarlet please review my pr

@MukjepScarlet MukjepScarlet marked this pull request as draft July 14, 2025 10:49
@MukjepScarlet MukjepScarlet marked this pull request as ready for review July 14, 2025 14:09
@sqlerrorthing
Copy link
Contributor

sqlerrorthing commented Jul 15, 2025

This is in progress, today I'll send a video of it

Please 🙏 do it in another pr (in ur repo) and mention me in this pr

@MukjepScarlet
Copy link
Contributor Author

QQ2025715-214944.mp4

@MukjepScarlet MukjepScarlet marked this pull request as ready for review July 15, 2025 13:51
@sqlerrorthing
Copy link
Contributor

sqlerrorthing commented Jul 15, 2025

good! add aniamtion to the arrow like scale or smth move to right and back when clicking & hovering

@sqlerrorthing
Copy link
Contributor

@MukjepScarlet what remains to do?

@MukjepScarlet
Copy link
Contributor Author

Nothing

@sqlerrorthing
Copy link
Contributor

good, put screenshots & videos into pr description

@superblaubeere27
Copy link
Contributor

superblaubeere27 commented Jul 16, 2025

We will have to wait for a review by @SenkJu.

This will be done in 3-5 business years (see #5938)

@sqlerrorthing
Copy link
Contributor

@SenkJu we are orphans

@MukjepScarlet
Copy link
Contributor Author

Waiting...

@sqlerrorthing
Copy link
Contributor

Waiting...

3-5 business years

@sqlerrorthing
Copy link
Contributor

@superblaubeere27, why u or just... @1zun4 cant review it?

@1zun4
Copy link
Member

1zun4 commented Sep 3, 2025

Needs to be merged with upstream.

@MukjepScarlet
Copy link
Contributor Author

Needs permission to merge. @SenkJu

@MukjepScarlet
Copy link
Contributor Author

...

@VillainsRule

This comment was marked as spam.

@MukjepScarlet MukjepScarlet changed the title feat: Combo bind feat: combo bind (frontend) Dec 2, 2025
@MukjepScarlet MukjepScarlet added this to the 0.36.0 milestone Dec 2, 2025
Co-authored-by: sqlerrorthing <[email protected]>
@MukjepScarlet
Copy link
Contributor Author

This will be merged before 1.21.10.

@MukjepScarlet MukjepScarlet merged commit 10b95e3 into CCBlueX:nextgen Dec 10, 2025
3 checks passed
@MukjepScarlet MukjepScarlet deleted the feat/combo_bind branch December 10, 2025 15:38
@sqlerrorthing
Copy link
Contributor

㊗️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Bind with modifiers (ctrl/shift/option/command...)

5 participants