fix(BlockPlacer):not work with some times #7159
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When postMove=false, doPlacement runs at the start of the tick, but serverRotation hasn’t updated yet because the movement packet hasn’t been sent, so the check fails using the old rotation.
Chasteful
changed the title
Contributor
Author
|
Remove this override won’t cause any other bugs. In fact, if you don’t delete it, the BlockPlacer can act super sluggish when its cooldown = 0, also only rotate to the target but not place the block. |
Contributor
|
I don't think removing the raycast check, range check and constructing the interaction result with the ideal rotation after a rotation atempt is a good idea. (That are the effects of the code change) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When postMove=false, doPlacement runs at the start of the tick, but serverRotation hasn’t updated yet because the movement packet hasn’t been sent, so the check fails using the old rotation.