Skip to content

Conversation

@ShivaGupta-14
Copy link
Contributor

@ShivaGupta-14 ShivaGupta-14 commented Jan 18, 2026

Description

  • Replace DatePicker with DateTimePicker for end field in AddTaskDialog

  • Add end to dateTimeFields array in tests

  • Support both date-only and datetime formats for end

  • Mark task as completed when end date is set via task done command in backend

  • Show inline warning message when end date is selected

  • Add warning message visibility tests

  • Fixes: Add additional time picker for time(and date) based fields in AddTaskDialog #325

Checklist

  • Ran npx prettier --write . (for formatting)
  • Ran gofmt -w . (for Go backend)
  • Ran npm test (for JS/TS testing)
  • Added unit tests, if applicable
  • Verified all tests pass
  • Updated documentation, if needed

Additional Notes

Why task done is used: Taskwarrior does not allow setting an end date on a pending task. The only way is via task done end:<date>, which marks the task as completed. Future end dates are allowed (as discussed with maintainer), the inline warning informs users of completion behavior.

Screenshots:

Screenshot 2026-01-18 at 8 34 47 PM Screenshot 2026-01-18 at 8 43 47 PM

Video:

Screen.Recording.2026-01-19.at.12.34.40.AM.mov

@github-actions
Copy link

Thank you for opening this PR!

Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools.

Please take a moment to:

  • Check the "Files changed" tab
  • Leave comments on any lines for functions, comments, etc. that are important, non-obvious, or may need attention
  • Clarify decisions you made or areas you might be unsure about and/or any future updates being considered.
  • Finally, submit all the comments!

More information on how to conduct a self review:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

This helps make the review process smoother and gives us a clearer understanding of your thought process.

Once you've added your self-review, we'll continue from our side. Thank you!

@ShivaGupta-14 ShivaGupta-14 force-pushed the feat/325-addtaskdialog-end-datetime-picker branch from 918675a to 4c66c2d Compare January 18, 2026 15:17
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed end from cmdArgs (not allowed on pending tasks). Using task done end:<date> to set end date and mark task completed, the way in Taskwarrior.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the tests and added test for warning message

Copy link
Contributor Author

@ShivaGupta-14 ShivaGupta-14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review done, ready for review, open to feedback and suggestions

@ShivaGupta-14 ShivaGupta-14 force-pushed the feat/325-addtaskdialog-end-datetime-picker branch from 4c66c2d to dbcc89c Compare January 18, 2026 18:57
- Add DateTimePicker for end date in AddTaskDialog
- Mark task as completed when end date is set via `task done` command
- Show inline warning when end date is selected
- Update and add tests
@ShivaGupta-14 ShivaGupta-14 force-pushed the feat/325-addtaskdialog-end-datetime-picker branch from dbcc89c to 8d1bff7 Compare January 18, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add additional time picker for time(and date) based fields in AddTaskDialog

2 participants