Skip to content

ran npm install latest#98

Merged
bwang-icf merged 3 commits intomainfrom
brandon/BB2-4657-upgrade-api-extractor
Mar 27, 2026
Merged

ran npm install latest#98
bwang-icf merged 3 commits intomainfrom
brandon/BB2-4657-upgrade-api-extractor

Conversation

@bwang-icf
Copy link
Copy Markdown
Contributor

JIRA Ticket:
BB2-4657

What Does This PR Do?

Upgrades api-extractor using npm install api-extractor@latest --save

What Should Reviewers Watch For?

Any breaking site changes

Validation

Verified with yarn test in the sdk repo and a local run using sample client

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team security engineer's approval.

Copy link
Copy Markdown
Contributor

@JamesDemeryNava JamesDemeryNava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run npm ls minimatch, I still see minimatch version that are less than 10.2.3 shown. Should just be able to add that to the overrides in package.json.

@JamesDemeryNava JamesDemeryNava self-assigned this Mar 27, 2026
@JamesDemeryNava
Copy link
Copy Markdown
Contributor

@bwang-icf Now when I run npm ls minimatch, I see this:

cms-bluebutton-sdk@1.0.7 /Users/jamesdemery/github/cms-bb2-node-sdk ├─┬ @microsoft/api-extractor@7.57.7 │ └── minimatch@10.2.3 ├─┬ babel-jest@27.5.1 │ └─┬ babel-plugin-istanbul@6.1.1 │ └─┬ test-exclude@6.0.0 │ ├─┬ glob@7.2.3 │ │ └── minimatch@3.1.5 deduped invalid: "^10.2.3" from node_modules/eslint, "^10.2.3" from node_modules/@eslint/eslintrc, "^10.2.3" from node_modules/@humanwhocodes/config-array, "^10.2.3" from node_modules/test-exclude, "^10.2.3" from node_modules/glob │ └── minimatch@3.1.5 deduped invalid: "^10.2.3" from node_modules/eslint, "^10.2.3" from node_modules/@eslint/eslintrc, "^10.2.3" from node_modules/@humanwhocodes/config-array, "^10.2.3" from node_modules/test-exclude ├─┬ eslint@8.57.1 │ ├─┬ @eslint/eslintrc@2.1.4 │ │ └── minimatch@3.1.5 deduped invalid: "^10.2.3" from node_modules/eslint, "^10.2.3" from node_modules/@eslint/eslintrc │ ├─┬ @humanwhocodes/config-array@0.13.0 │ │ └── minimatch@3.1.5 deduped invalid: "^10.2.3" from node_modules/eslint, "^10.2.3" from node_modules/@eslint/eslintrc, "^10.2.3" from node_modules/@humanwhocodes/config-array │ └── minimatch@3.1.5 invalid: "^10.2.3" from node_modules/eslint, "^10.2.3" from node_modules/@eslint/eslintrc, "^10.2.3" from node_modules/@humanwhocodes/config-array └─┬ typedoc@0.23.0 └── minimatch@5.1.9 invalid: "^10.2.3" from node_modules/typedoc

From what I can see, you may need to also update the packages that were using the old version of minimatch, so something like:

npm install eslint@latest typedoc@latest babel-jest@latest

then run npm ls minimatch again to see what that looks like

Copy link
Copy Markdown
Contributor

@JamesDemeryNava JamesDemeryNava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nicely done

@bwang-icf bwang-icf merged commit 366db0a into main Mar 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants