fix: include runner image version in macOS Octave cache key#337
Merged
Conversation
The cache key was only keyed on the Octave version, but cached dependencies like open-mpi link against pre-installed runner libs (e.g. libevent). When the runner image updates those libs, the cached packages break with dyld load errors (exit code 134). Including ImageVersion in the cache key ensures the cache is invalidated whenever the runner image changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
=======================================
Coverage 92.90% 92.90%
=======================================
Files 6 6
Lines 437 437
=======================================
Hits 406 406
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Fixes a recurring macOS CI failure where Octave crashes with exit code 134 due to a missing
libeventdylib. The cachedopen-mpiwas compiled againstlibevent_core-2.1.7.dylibfrom the runner image at cache-build time, but when the runner image updatedlibevent, that dylib was no longer present.Changes
$ImageVersion) in the macOS Octave cache key (macos-brew-octave-<version>-image-<ImageVersion>), so the cache is automatically invalidated whenever the runner image changes and pre-installed brew dependency versions may have shifted.Backwards-incompatible changes
None
Testing
The existing stale cache will be abandoned on the next run; a fresh
brew install octavewill build a new cache entry tied to the current image, and subsequent runs will restore a coherent set of libraries.AI usage