Fix follower tab counts, achievement styling, and link URLs#6252
Merged
Fix follower tab counts, achievement styling, and link URLs#6252
Conversation
- Fix follower page tab counts showing "-" instead of numbers by adding count_id support to TabBar component and using it in FollowersPage - Fix achievement badge SVG sizing by pre-setting width/height on SVG placeholders to prevent external-svg-loader from copying large pt-based dimensions, add variant classes to container divs, simplify coin CSS - Fix follower page profile links missing theme prefix causing 404s by passing theme via data attribute and using it in URL construction - Fix profile achievements not loading for guests by using plain fetch instead of ApiFetch which always sends auth headers - Move most-recent-achievement section above tabs to match original layout - Constrain follower card avatar size to 4rem - Add Behat tests for follower page tab counts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6252 +/- ##
=============================================
- Coverage 54.58% 52.85% -1.73%
Complexity 8369 8369
=============================================
Files 756 756
Lines 26801 26801
=============================================
- Hits 14629 14167 -462
- Misses 12172 12634 +462
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
count_idsupport toTabBarcomponent)width/heighton SVG placeholders to blockexternal-svg-loaderfrom copying pt-based dimensions)/user/123instead of/app/user/123) causing 404sApiFetchalways sends auth header, replaced with plainfetchfor public endpoint)Test plan
/app/follower) shows correct numeric counts in tabs/app/achievements/app/user/{id}profile pagesbin/behat -s web-profile tests/BehatFeatures/web/profile/follow.feature— all 10 scenarios pass🤖 Generated with Claude Code