Skip to content

Fix follower tab counts, achievement styling, and link URLs#6252

Merged
dmetzner merged 1 commit intodevelopfrom
fix/follower-achievements-ui-fixes
Mar 2, 2026
Merged

Fix follower tab counts, achievement styling, and link URLs#6252
dmetzner merged 1 commit intodevelopfrom
fix/follower-achievements-ui-fixes

Conversation

@dmetzner
Copy link
Collaborator

@dmetzner dmetzner commented Mar 2, 2026

Summary

  • Fix follower page tab counts showing "-" instead of numbers (added count_id support to TabBar component)
  • Fix achievement badge SVGs rendering at massive sizes (pre-set width/height on SVG placeholders to block external-svg-loader from copying pt-based dimensions)
  • Fix follower page profile links missing theme prefix (e.g. /user/123 instead of /app/user/123) causing 404s
  • Fix profile page achievements not loading for guest users (ApiFetch always sends auth header, replaced with plain fetch for public endpoint)
  • Move most-recent-achievement section above tabs to match original layout
  • Constrain follower card avatar images to 4rem

Test plan

  • Verify follower page (/app/follower) shows correct numeric counts in tabs
  • Verify follower page links to user profiles work (include theme prefix)
  • Verify achievement badges render at correct size on /app/achievements
  • Verify achievement badges render at correct size on /app/user/{id} profile pages
  • Verify achievements show on profile pages when not logged in
  • Verify most-recent-achievement section appears above the tab bar
  • Run bin/behat -s web-profile tests/BehatFeatures/web/profile/follow.feature — all 10 scenarios pass

🤖 Generated with Claude Code

- Fix follower page tab counts showing "-" instead of numbers by adding
  count_id support to TabBar component and using it in FollowersPage
- Fix achievement badge SVG sizing by pre-setting width/height on SVG
  placeholders to prevent external-svg-loader from copying large pt-based
  dimensions, add variant classes to container divs, simplify coin CSS
- Fix follower page profile links missing theme prefix causing 404s by
  passing theme via data attribute and using it in URL construction
- Fix profile achievements not loading for guests by using plain fetch
  instead of ApiFetch which always sends auth headers
- Move most-recent-achievement section above tabs to match original layout
- Constrain follower card avatar size to 4rem
- Add Behat tests for follower page tab counts

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.85%. Comparing base (544e477) to head (2403e60).
⚠️ Report is 15 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6252      +/-   ##
=============================================
- Coverage      54.58%   52.85%   -1.73%     
  Complexity      8369     8369              
=============================================
  Files            756      756              
  Lines          26801    26801              
=============================================
- Hits           14629    14167     -462     
- Misses         12172    12634     +462     
Flag Coverage Δ
behat 50.34% <ø> (-1.91%) ⬇️
phpunit 10.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dmetzner dmetzner enabled auto-merge March 2, 2026 18:36
@dmetzner dmetzner disabled auto-merge March 2, 2026 18:36
@dmetzner dmetzner merged commit d5f1138 into develop Mar 2, 2026
53 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant