[ENG-10829] Embargoed Registration — End Embargo Early Button Missing#982
Open
mkovalua wants to merge 2 commits intoCenterForOpenScience:feature/pbs-26-9from
Open
[ENG-10829] Embargoed Registration — End Embargo Early Button Missing#982mkovalua wants to merge 2 commits intoCenterForOpenScience:feature/pbs-26-9from
mkovalua wants to merge 2 commits intoCenterForOpenScience:feature/pbs-26-9from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A subset of users are unable to end their embargoed registrations early. The "End Embargo Early" button is not appearing as expected, and users instead see the error text registry.overview.statuses.None.text on the registration overview page. This was previously resolved on a case-by-case basis by cloud engineering, but a permanent fix is now required.
Summary of Changes
if
registry.overview.statuses.None.textuse
registry.overview.endEmbargoas default for statusesScreenshot(s)
Side Effects
https://openscience.atlassian.net/browse/ENG-10829?focusedCommentId=119176
I suppose the solution may be to use registry.overview.endEmbargo as default if registry()?.status= None if None might be saved into database only for Embargoed registrations and not affect other status types. Otherwise it may be expected any other approach .
QA Notes